Race on LOAD DATA called from different routines #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks, great find!!!
Thanks again! |
Maps are not routine safe so if you register readers/files from differents routines, the registry must be locked.
|
I have done the changes according to your review :) |
|
LGTM, thanks again! |
arnehormann
added a commit
that referenced
this pull request
Nov 12, 2015
Race on LOAD DATA called from different routines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I experienced some data races when loading readers from different routines, so I created this PR, thanks !
"Maps are not routine safe so if you register readers/files from differents routines, the
registry must be locked."